-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compositor "scripts" for the batch renderer #1969
Draft
mosra
wants to merge
12
commits into
main
Choose a base branch
from
batch-renderer-compositors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,221
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosra
added
the
do not merge
Not ready to merge. This label should block merging.
label
Dec 16, 2022
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Dec 16, 2022
mosra
force-pushed
the
batch-renderer-compositors
branch
3 times, most recently
from
December 18, 2022 12:24
0240098
to
8754cf2
Compare
11 tasks
mosra
force-pushed
the
batch-renderer-compositors
branch
from
December 20, 2022 22:00
a343d9c
to
c8506b1
Compare
It mainly makes the nested filenames together with corresponding transformations available, not much else.
The unit test might be useful on its own, without the composite part. TODO: all the TODOs, add remaining ground truth images TODO: remove the commented-out portions of the code
mosra
force-pushed
the
batch-renderer-compositors
branch
from
March 24, 2023 18:30
c8506b1
to
07d0b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Do not delete this pull request or issue due to inactivity.
do not merge
Not ready to merge. This label should block merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
For creating the ReplicaCAD, YCB and Fetch composite files I posted on Slack. Pushing as a PR so the code is available but with no intention to ever merge this.
How to use
All three executables create a glTF file as an output, with the meshes joined together and referenced via a placeholder
MAGNUMX_mesh_views
extension, a material for every such mesh view and an uncompressed 2D array KTX texture, because that's the fastest. You can also use*.glb
instead of*.gltf
for the output file, which makes it self-contained, but that makes any introspection / debugging or further texture operations from below rather painful to perform.The KTX texture, if you don't want to use it directly, can then be further processed either with Basis (which will likely be annoyingly slow, memory-hungry and time-consuming):
Or, for a faster turnaround times, a cheap & quick block-compressed DXT texture:
Eventually I'll add more compression alternatives, such as BC7 and ASTC.
Easiest is to take the
magnum-imageconverter
executable either from Homebrew on macOS or from the prebuilt Linux binaries: https://github.com/mosra/magnum-ci/actions/workflows/magnum-tools.ymlReplicaCAD compositor
Expects a folder named
ReplicaCAD_dataset_v1.5
in thepath/to/datasets
directory. I.e., it does not use the directory structure used by thedataset_download.py
script to avoid accidental version mismatches.YCB compositor
Expects a folder named
hab_ycb_v1.2
in thepath/to/datasets
directory.Fetch compositor
Expects a folder named
hab_fetch_v1.0
in thepath/to/datasets
directory.How Has This Been Tested
Works On My Machine™